Skip to content

Add support for Blackpill F401CC #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 23, 2019
Merged

Add support for Blackpill F401CC #567

merged 7 commits into from
Jul 23, 2019

Conversation

@BennehBoy
Copy link
Contributor

@BennehBoy BennehBoy commented Jul 22, 2019

This PR adds support for the Blackpill F401CC

Please see issue #545

I've tweaked the peripheralpins.c slightly.

Tested with SPI, I2C, UART1, VCP

Could do with GPIO/ADC testing.

@BennehBoy
Copy link
Contributor Author

BennehBoy commented Jul 22, 2019 •
edited
Loading

@fpistm I tried to make it so none of the PWM timers clashed, in short PA6 & PB5 share TIM3_CH1 - presumably this is only a problem if anyone tries to use both as PWM?

@BennehBoy
Copy link
Contributor Author

BennehBoy commented Jul 22, 2019

More info on the boards here -> https://www.stm32duino.com/viewtopic.php?f=39&t=4701

@fpistm fpistm self-requested a review July 22, 2019 14:23
@fpistm fpistm added the new variant Add support of new bard label Jul 22, 2019
@fpistm fpistm added this to the 1.7.0 milestone Jul 22, 2019
fpistm
fpistm requested changes Jul 22, 2019
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BennehBoy
Here a first quick review.

@BennehBoy
Copy link
Contributor Author

BennehBoy commented Jul 22, 2019

It's always the little last minute changes that catch you out lol

BennehBoy and others added 3 commits July 22, 2019 15:45
@BennehBoy
fix up review items
54a9bbd
@BennehBoy
un-astyle ldscript.ld LD
7eedc7e
@fpistm
Review
61d9a7c 
* Update PeripheralPins.c to avoid duplicated pins.
Comment some USB pins as I guess not used.
* Update TIMER_TONE and TIMER_SERVO definitions,
aligned with HardwareTimer implementation (coming soon)
* Small typos and code format

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Copy link
Member

fpistm commented Jul 22, 2019

@BennehBoy,
thanks for the update, I've made a deeper review and made a PR on your fork with it.
Did you test USB ?

@BennehBoy
Copy link
Contributor Author

BennehBoy commented Jul 22, 2019

Only insofar that it enumerates as CDC on Win 10.

fpistm
fpistm approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm merged commit 8c2b8b6 into stm32duino:master Jul 23, 2019
@fpistm
Copy link
Member

fpistm commented Jul 23, 2019

@fpistm I tried to make it so none of the PWM timers clashed, in short PA6 & PB5 share TIM3_CH1 - presumably this is only a problem if anyone tries to use both as PWM?

If pins shared the same timer and channel, the same PWM will be output on both.

@BennehBoy
Copy link
Contributor Author

BennehBoy commented Jul 23, 2019

Hmm, so it's probably worth submitting another PR to comment out PA6 as an available PWM pin as it's more than likely going to be used for SPI anyway, would you agree?

@fpistm
Copy link
Member

fpistm commented Jul 23, 2019

Yes

@BennehBoy BennehBoy deleted the PILL_F401XX branch July 24, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fpistm fpistm fpistm approved these changes

Assignees

@BennehBoy BennehBoy

Labels

new variant Add support of new bard

Projects

None yet

Milestone

1.7.0

Development

Successfully merging this pull request may close these issues.

2 participants

@BennehBoy @fpistm